On Mon, Sep 28, 2020 at 03:18:18PM +0530, Amit Pundir wrote: > On Sun, 27 Sep 2020 at 18:06, <kholk11@xxxxxxxxx> wrote: > > > > From: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx> > > > > This is a driver for the Novatek in-cell touch controller and > > supports various chips from the NT36xxx family, currently > > including NT36525, NT36672A, NT36676F, NT36772 and NT36870. > > > > Functionality like wake gestures and firmware flashing is not > > included: I am not aware of any of these DrIC+Touch combo > > chips not including a non-volatile memory and it should be > > highly unlikely to find one, since the touch firmware is > > embedded into the DriverIC one, which is obviously necessary > > to drive the display unit. > > > > However, the necessary address for the firmware update > > procedure was included into the address table in this driver > > so, in the event that someone finds the need to implement it > > for a reason or another, it will be pretty straightforward to. > > > > This driver is lightly based on the downstream implementation [1]. > > [1] https://github.com/Rasenkai/caf-tsoft-Novatek-nt36xxx > > > > This is so cool! > > Xiaomi PocoF1 phone uses same family touchscreen IC and I could > test this series on that phone as well. > > However I do have to make a minor change to get it working. The > downstream driver and even the github code you linked above use > GPIO mapped IRQ, and I had to switch to that to get touchscreen > working with your driver > https://github.com/pundiramit/linux/commit/0a73eb656c1e80787dc195641ce7b0076fddb38e. > I wonder if I'm missing any devicetree property other than interrupts? Simply specifying GPIO controller/pin as interrupt property should work, there should be no need to parse custom GPIO property and convert it to IRQ in the driver. Thanks. -- Dmitry
