14.09.2020 18:50, Andy Shevchenko пишет: ... >> It's more preferred >> to accept patch as-is if it does right thing and then maintainer could >> modify the patch, making cosmetic changes. > > It depends on the maintainer's workflow (which may be different from > maintainer to maintainer). Sure! It's awesome that you're pointing out it all in the reviews because it's important to have such things explained and definitely should help to improve quality of further of patches! But it shouldn't be necessary to demand a very minor changes, IMO. In particular Jiada was submitting this and lots of other atmel_mxt_ts patches for about a year now without much progress yet, and you probably should know how a frustrating experience this could be for a contributor since you're a longtime kernel developer.