Hi Vincent, On Wed, Sep 09, 2020 at 04:36:32PM +0800, Vincent Huang wrote: > Add trackpoint variant IDs to allow supported control > on Synaptics trackpoints > > Signed-off-by: Vincent Huang <vincent.huang@xxxxxxxxxxxxxxxx> > --- > drivers/input/mouse/trackpoint.c | 2 ++ > drivers/input/mouse/trackpoint.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c > index 3eefee2ee2a1..c54d2f9e1c4a 100644 > --- a/drivers/input/mouse/trackpoint.c > +++ b/drivers/input/mouse/trackpoint.c > @@ -21,6 +21,8 @@ static const char * const trackpoint_variants[] = { > [TP_VARIANT_ALPS] = "ALPS", > [TP_VARIANT_ELAN] = "Elan", > [TP_VARIANT_NXP] = "NXP", > + [TP_VARIANT_JYT_SYNAPTICS] = "JYT_SYNAPTICS", > + [TP_VARIANT_SYNAPTICS] = "SYNAPTICS", Do these need to be capitalized? This is simply used in log messages, so nicer formatted strings can be used. Thanks. -- Dmitry