05.09.2020 21:02, Andy Shevchenko пишет: ... > #define MXT_CRC_TIMEOUT 1000 /* msec */ > #define MXT_FW_RESET_TIME 3000 /* msec */ > #define MXT_FW_CHG_TIMEOUT 300 /* msec */ > +#define MXT_WAKEUP_TIME 25 /* msec */ > > > Can we simple add _MS unit suffix to the definition? I'd expect this > /* Command to unlock bootloader */ > #define MXT_UNLOCK_CMD_MSB 0xaa > @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client, > struct i2c_msg xfer[2]; > u8 buf[2]; > int ret; > + bool retry = false; > > > Keep this ordered by length. and this to be separate patches that are cleaning whole driver code, otherwise there are no much benefits.
