On Mon, Aug 24, 2020 at 03:35:16PM +0000, Walter Harms wrote: > hello Dan, > > i notice that you can shorten the line to: > (line above checks for count==sizeof(struct kone_settings)) > > difference = memcmp(settings, &kone->settings, count); > > nothing special just to shorten the line and make use of count. > > and just to save one indent level and because its readabel nicely: > if ( ! difference ) > goto unlock; > > hope that helps Yeah. I wrote that version and I wanted to send it, but then I decided not to change the style too much. I definitely agree with you, but I figured I would keep the patch less intrusive. regards, dan carpenter
