Re: [PATCH v6 2/4] SFH: PCIe driver to add support of AMD sensor fusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sandeep,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.8 next-20200807]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sandeep-Singh/SFH-Add-Support-for-AMD-Sensor-Fusion-Hub/20200809-182729
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 06a81c1c7db9bd5de0bd38cd5acc44bb22b99150
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/hid/amd-sfh-hid/amd_mp2_pcie.c: In function 'amd_mp2_pci_init':
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:107:2: warning: ignoring return value of 'pcim_enable_device', declared with attribute warn_unused_result [-Wunused-result]
     107 |  pcim_enable_device(pdev);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/pcim_enable_device +107 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c

   101	
   102	static int amd_mp2_pci_init(struct amd_mp2_dev *privdata, struct pci_dev *pdev)
   103	{
   104		int rc;
   105	
   106		pci_set_drvdata(pdev, privdata);
 > 107		pcim_enable_device(pdev);
   108		pcim_iomap_regions(pdev, BIT(2), DRIVER_NAME);
   109	
   110		privdata->mmio = pcim_iomap_table(pdev)[2];
   111		pci_set_master(pdev);
   112	
   113		rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
   114		if (rc)
   115			rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
   116		return rc;
   117	}
   118	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux