On Thu, July 30, 2020 2:10 PM, Dmitry Torokhov > On Wed, Jul 29, 2020 at 02:09:48PM +0000, Roy Im wrote: > > Wednesday, July 29, 2020 3:37 PM, Dmitry Torokhov wrote: > > > On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote: > > > > v11: > > > > - Updated the pwm related code, comments and typo. > > > > v10: > > > > - Updated the pwm related function and added some comments. > > > > v9: > > > > - Removed the header file and put the definitions into the c file. > > > > - Updated the pwm code and error logs with %pE > > > > > > I believe the %pE is to format an escaped buffer, you probably want > > > to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or > we should stick with %d as most of the kernel does. > > > > Right, it should be %pe as you and Uwe said, Uwe suggested %pe to understand easier.. do you still prefer to stick with %d? > > Depends on the situation. If you already have ERR_PTR-encoded error there is no reason for not using %pe, but if you have > integer error, or you have already converted pointer to integer I'd prefer we stick with %d. > > As I mentioned in another message maybe we should consider adding '%de' > or similar for formatting integer errors. I have seen the discussion messages in another email, then I am not still quite sure what could be good for now. Do you still prefer to be with %d if I have already converted pointer to integer and with %pe for something that I already have ERR_PTR-encoded error? Kind regards, Roy
