Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 20-07-23 10:43, Horia Geantă wrote:
> From: André Draszik <git@xxxxxxxxxx>
> 
> The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
> 
> This driver here should only return IRQ_HANDLED if the status register
> indicates that the event we're handling in the irq handler was genuinely
> intended for this driver. Otheriwse the interrupt subsystem will
> assume the interrupt was handled successfully even though it wasn't
> at all.

After checking the RM and the imx6qdl.dtsi I'm not very sure that this
is right since the snvs-powerkey has a seperate irq-line. So we can be
sure that this irq is for us. If this is the case we don't need to check
the SNVS_LPSR_REG instead we only need to clear it.

Regards,
  Marco



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux