On Fri, 12 Jun 2020, Kai-Heng Feng wrote: > >>> PCI_DEV_FLAGS_NO_D3 should not be used outside of PCI core. > >>> > >>> Instead, we can use pci_save_state() to hint PCI core that the device > >>> should stay at D0 during suspend. > >> > >> Your changes are doing more than just changing the flag. Can you > >> explain more about the other changes? > > > > By using pci_save_state(), in addition to keep itself stay at D0, the parent bridge will also stay at D0. > > So it's a better approach to achieve the same thing. > > > >> Also make sure that you test on both platforms which has regular S3 and > >> S0ix (modern standby system). > > > > Actually I don't have any physical hardware to test the patch, I found the issue when I search for D3 quirks through the source code. > > > > Can you guys do a quick smoketest for this patch? > > Tested this patch on an S2idle system with intel-ish (Latitude 9510) and > it works fine. Please consider merging this patch, thanks! Thanks for testing. Could you please resubmit v2 with the updated changelog (explaining the relationship to the parent bridge mode and the related changes your code is doing), and resubmit so that I can queue it in hid.git? Thanks. -- Jiri Kosina SUSE Labs
