Re: [PATCH v1 2/3] drivers: input: misc: Add mtk vibrator driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fengping,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on pavel-linux-leds/for-next v5.8-rc1 next-20200615]
[cannot apply to input/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Fengping-Yu/dt-bindings-Add-vibrator-devicetree-documentation/20200615-204209
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/device.h:15,
from drivers/input/misc/regulator-vibrator.c:7:
drivers/input/misc/regulator-vibrator.c: In function 'mt_vibra_parse_dt':
>> drivers/input/misc/regulator-vibrator.c:70:16: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
70 |   dev_err(dev, "error load dts: get regulator return %dn",
|                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
|                      ^~~
>> drivers/input/misc/regulator-vibrator.c:70:3: note: in expansion of macro 'dev_err'
70 |   dev_err(dev, "error load dts: get regulator return %dn",
|   ^~~~~~~
drivers/input/misc/regulator-vibrator.c:70:55: note: format string is defined here
70 |   dev_err(dev, "error load dts: get regulator return %dn",
|                                                      ~^
|                                                       |
|                                                       int
|                                                      %ld
drivers/input/misc/regulator-vibrator.c: In function 'vib_probe':
drivers/input/misc/regulator-vibrator.c:334:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
334 |  if (ret) {
|     ^

vim +70 drivers/input/misc/regulator-vibrator.c

    46	
    47	static int mt_vibra_parse_dt(struct device *dev,
    48			struct reg_vibr_config *vibr_conf)
    49	{
    50		int ret;
    51	
    52		if (device_property_read_u32(dev, "min-limit",
    53					     &vibr_conf->min_limit))
    54			vibr_conf->min_limit = DEFAULT_MIN_LIMIT;
    55		vibr_conf->min_limit = max_t(unsigned int,
    56			vibr_conf->min_limit, DEFAULT_MIN_LIMIT);
    57	
    58		if (device_property_read_u32(dev, "max-limit",
    59					     &vibr_conf->max_limit))
    60			vibr_conf->max_limit = 0;
    61	
    62		if (!vibr_conf->max_limit &&
    63			vibr_conf->max_limit < vibr_conf->min_limit) {
    64			dev_err(dev, "error load dts: get error limitation(min > max)\n");
    65			return -EINVAL;
    66		}
    67	
    68		vibr_conf->reg = devm_regulator_get(dev, "vib");
    69		if (IS_ERR(vibr_conf->reg)) {
  > 70			dev_err(dev, "error load dts: get regulator return %d\n",
    71				PTR_ERR(vibr_conf->reg));
    72			vibr_conf->reg = NULL;
    73			return PTR_ERR(vibr_conf->reg);
    74		}
    75	
    76		if (device_property_read_u32(dev, "max-volt",
    77					     &vibr_conf->max_volt)) {
    78			dev_err(dev, "error load dts: get max-volt failed\n");
    79			return -EINVAL;
    80		}
    81	
    82		if (device_property_read_u32(dev, "min-volt",
    83					     &vibr_conf->min_volt)) {
    84			dev_err(dev, "error load dts: get min-volt failed!\n");
    85			return -EINVAL;
    86		}
    87	
    88		if (vibr_conf->min_volt > vibr_conf->max_volt) {
    89			dev_err(dev, "error load dts: get error voltage(min > max)\n");
    90			return -EINVAL;
    91		}
    92	
    93		dev_info(dev, "vibr_conf = %u, %u, %u-%u\n",
    94			 vibr_conf->min_limit, vibr_conf->max_limit,
    95			 vibr_conf->min_volt, vibr_conf->max_volt);
    96	
    97		return ret;
    98	}
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux