On Sun, Jun 14, 2020 at 4:27 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Sun, Jun 14, 2020 at 8:58 AM Navid Emamdoost > <navid.emamdoost@xxxxxxxxx> wrote: > > > > in bma150_open, pm_runtime_get_sync is called which > > increments the counter even in case of failure, leading to incorrect > > ref count. In case of failure, decrement the ref count before returning. > > ... > > > error = pm_runtime_get_sync(&bma150->client->dev); > > if (error < 0 && error != -ENOSYS) > > - return error; > > + goto out; > > So, what will happen in case of -ENOSYS? I'm not sure! > > ... > > > + pm_runtime_put(&bma150->client->dev); > > Slightly better to use _put_noidle(). (More consistency with error path) v2 is sent. > > -- > With Best Regards, > Andy Shevchenko -- Navid.
