On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote: > From: "fengping.yu" <fengping.yu@xxxxxxxxxxxx> > > This adds matrix keypad support for Mediatek SoCs. ... > +config KEYBOARD_MTK_KPD > + tristate "MediaTek Keypad Support" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + select CONFIG_REGMAP_MMIO This is wrong. > + select INPUT_MATRIXKMAP ... > + ret = devm_add_action_or_reset(&pdev->dev, kpd_clk_disable, > + keypad->clk); I would leave on one line (only 81 characters). > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko
