On Wed, May 27, 2020 at 11:00:48AM +0200, Marco Felsch wrote:
> On 20-05-27 16:31, Fengping Yu wrote:
> > + irqnr = platform_get_irq(pdev, 0);
> > + if (irqnr < 0)
> > + return -irqnr;
> ^
> irqnr is already negative
>
> > + ret = devm_request_threaded_irq(&pdev->dev, irqnr,
> > + NULL, kpd_irq_handler, 0,
> > + MTK_KPD_NAME, keypad);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n",
> > + irqnr, ret);
>
> Still not alligned.
>
> > + return ret;
> > + }
And on top, can't we use irq instead of irqnr?
--
With Best Regards,
Andy Shevchenko
