Hi Macro, On Thu, Feb 27, 2020 at 12:28:16PM +0100, Marco Felsch wrote: > Since commit b6eba86030bf ("Input: edt-ft5x06 - add offset support for > ev-ft5726") offset-x and offset-y is supported. Devices using those > offset parameters don't support the offset parameter so we need to add > the NO_REGISTER check for edt_ft5x06_ts_get_defaults(). > > Fixes: b6eba86030bf ("Input: edt-ft5x06 - add offset support for ev-ft5726") > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> I'll apply this, but I wonder if we should not move this check into edt_ft5x06_register_write(), and also have edt_ft5x06_register_read() return error if address is "NO_REGISTER"? Thanks. -- Dmitry