26.04.2020 08:15, Dmitry Torokhov пишет: > On Mon, Apr 13, 2020 at 03:32:26PM +0200, Michał Mirosław wrote: >> From: Dmitry Osipenko <digetx@xxxxxxxxx> >> >> eKTF3624 touchscreen firmware uses two variants of the reply opcodes for >> reporting touch events: one is 0x63 (used by older firmware) and other is >> 0x66 (used by newer firmware). The 0x66 variant is equal to 0x63 of >> eKTH3500, while 0x63 needs small adjustment of the touch pressure value. >> >> Nexus 7 tablet device has eKTF3624 touchscreen and it uses 0x66 opcode for >> reporting touch events, let's support it now. Other devices, eg. ASUS TF300T, >> use 0x63. >> >> Note: CMD_HEADER_REK is used for replying to calibration requests, it has >> the same 0x66 opcode number which eKTF3624 uses for reporting touches. >> The calibration replies are handled separately from the the rest of the >> commands in the driver by entering into ELAN_WAIT_RECALIBRATION state >> and thus this change shouldn't change the old behavior. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> Tested-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> >> Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> >> --- >> drivers/input/touchscreen/elants_i2c.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c >> index 2b936e920874..9751139e8507 100644 >> --- a/drivers/input/touchscreen/elants_i2c.c >> +++ b/drivers/input/touchscreen/elants_i2c.c >> @@ -60,6 +60,15 @@ >> #define QUEUE_HEADER_NORMAL 0X63 >> #define QUEUE_HEADER_WAIT 0x64 >> >> +/* >> + * Depending on firmware version, eKTF3624 touchscreens may utilize one of >> + * these opcodes for the touch events: 0x63 and 0x66. The 0x63 is used by >> + * older firmware version and differs from 0x66 such that touch pressure >> + * value needs to be adjusted. > > Who is responsible for the adjustment? Where does it happen? Please see the patch #2 ("support old touch report format") which adds support for parsing of the older packet format that requires the pressure value adjustment.