Hi Haibo, On Fri, Apr 10, 2020 at 9:51 AM <haibo.chen@xxxxxxx> wrote: > > From: Haibo Chen <haibo.chen@xxxxxxx> > > According to the User Guide, the get firmware command is > { 0x03, 0x03, 0xa, 0x01, 'D' }, ASCII value of 'D' is 0x44. > > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> > --- > drivers/input/touchscreen/egalax_ts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c > index c816e03ba421..bb0a59d19f34 100644 > --- a/drivers/input/touchscreen/egalax_ts.c > +++ b/drivers/input/touchscreen/egalax_ts.c > @@ -171,10 +171,10 @@ static int egalax_wake_up_device(struct i2c_client *client) > > static int egalax_firmware_version(struct i2c_client *client) > { > - static const u8 cmd[MAX_I2C_DATA_LEN] = { 0x03, 0x03, 0xa, 0x01, 0x41 }; > + static const u8 get_firmware_cmd[MAX_I2C_DATA_LEN] = { 0x03, 0x03, 0xa, 0x01, 0x44 }; The rename from 'cmd' to 'get_firmware_cmd' is an unrelated change. The only change I would expect to see in this patch is 0x41 to 0x44. Since this is bug fix, please add a Fixes tag. Thanks