On Wed, 2020-04-01 at 11:14 +0200, Hans de Goede wrote: > Hi, > > On 4/1/20 3:45 AM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Wed, Mar 25, 2020 at 04:02:46PM +0100, Hans de Goede wrote: > > > acpi_evaluate_object() and acpi_execute_simple_method() are not > > > part of > > > the group of ACPI related functions which get stubbed by > > > include/linux/acpi.h when ACPI support is disabled, so the > > > IRQ_PIN_ACCESS_ACPI_METHOD handling code must be disabled through > > > an #ifdef when ACPI support is not enabled. > > > > > > For consistency also #ifdef out the IRQ_PIN_ACCESS_ACPI_GPIO code > > > and use the same #if condition as which is used to replace > > > goodix_add_acpi_gpio_mappings with a stub. > > > > I am not big fun of multiple #ifdefs sprinkled through the code, > > can we > > do more straightforward stubs, like below? > > The solution you suggested is fine with me. The patch itself is slightly confusing (it looks like it's renaming functions), but looks pretty much like I requested, so: Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>
