On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra <nehal-bakulchandra.shah@xxxxxxx> wrote: > On 3/31/2020 6:01 PM, Richard Neumann wrote: > > Not a real review, but your patch series seems to be repeating a lot > > from drivers/i2c/busses/i2c-amd-mp2*. > > Is there any chance we could re-use the code? > > E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd-mp2.h? > > Thanks for the mail. Yes there are some common structures, however as of now we have kept separately considering both > > are part of different sub systems. But may be will consider this input for future enhancement. It can be done in a form of shared definitions at least in include/linux/platform_data/x86/amd-mp2.h or alike ... -- With Best Regards, Andy Shevchenko
