On 16.03.20 15:40, Andy Shevchenko wrote: > On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote: >> Add simple fw_version file in debugfs to read the value from 0xa6 >> which is the firmware version. > > > If you switch to regmap I²C API you will get this for free for all defined > registers. > > So, I highly recommend to consider above. > I don't know all the devices and modes well enough if the current raw read/write buffers always translate to (only) buf[0] being the register address. If you tell me I can assume just that, I'm happy to do a larger change that completely does aways with the current raw buffers. Otherwise: Does is make sense to *add* just a few regmap calls but keep the current i2c_transfer in place for the calls I'm not sure about? I could do that in any case. thanks! martin