On 16/03/2020 08:44:10+0000, Anson Huang wrote: > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On 16/03/2020 08:04:17+0000, Anson Huang wrote: > > > Hi, Shawn > > > > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for > > > > !CONFIG_IMX_SCU case > > > > > > > > On Mon, Mar 16, 2020 at 03:18:43AM +0000, Peng Fan wrote: > > > > > Just sent out. One more thing, I think all drivers depends on > > > > > IMX_SCU should not have COMPILE_TEST if we plan not to add dummy > > > > > functions. I see you picked up Anson's patch in imx/drivers branch, > > please check more. > > > > > > > > Ha, yes. COMPILE_TEST should be dropped for IMX_SCU_PD in Anson's > > patch. > > > > Thanks for reminding. > > > > > > I still NOT quite understand why we won't support COMPILE_TEST for SCU > > > drivers, with whose stubs, the build should be OK, if there is any > > > build error, we should try to fix it, NOT just remove the COMPILE_TEST > > support, any special reason? > > > > > > > COMPILE_TEST is supported as long as IMX_SCU is selected like is it for any > > driver depending on any bus. > > But without having " || COMPILE_TEST " in kconfig, COMPILE_TEST will NOT be supported, > I think as long as we have stubs for those SCU APIs, all drivers depending on IMX_SCU can > support COMPILE_TEST independently. > Why do you absolutely need to compile them independently? From a code coverage point of view, having: COMPILE_TEST=y CONFIG_IMX_SCU=y is enough to select and compile the remaining drivers. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
