> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > case > > On 3/9/20 4:06 AM, Alexandre Belloni wrote: > > On 09/03/2020 08:38:14+0800, Anson Huang wrote: > >> Add stubs for those i.MX SCU APIs to make those modules depending on > >> IMX_SCU can pass build when COMPILE_TEST is enabled. > >> > >> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > >> --- > >> Changes since V2: > >> - return error for stubs. > > > > I'm not sure why you are sending v3 with the stubs as we determined > > that > > 2/7 is enough to compile all the drivers with COMPILE_TEST. > > > > > 2/7 alone is not sufficient. With only 2/7, one can explicitly configure > IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, one > should not do that, but 0day does (I don't know if that is the result of > RANDCONFIG), and I am not looking forward having to deal with the fallout. So the V3 patch series looks better, adding stubs can cover various corner cases. Anson
