On 07/03/2020 01:36:39+0000, Anson Huang wrote: > Hi, Alexandre > > > Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for > > KEYBOARD_IMX_SC_KEY > > > > On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote: > > > On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov > > > <dmitry.torokhov@xxxxxxxxx> wrote: > > > > > > > > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote: > > > > > Add COMPILE_TEST support to i.MX SC keyboard driver for better > > > > > compile testing coverage. > > > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > > > > > > Applied, thank you. > > > > > > Actually, not: > > > > > > ERROR: "imx_scu_irq_register_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] > > undefined! > > > ERROR: "imx_scu_irq_unregister_notifier" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > ERROR: "imx_scu_irq_group_enable" > > > [drivers/input/keyboard/imx_sc_key.ko] undefined! > > > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > > > make: *** [Makefile:1282: modules] Error 2 > > > > > > If you want to enable compile test coverage you need to provide stubs > > > for the above functions. > > > > > > > or select IMX_SCU > > > > or leave out COMPILE_TEST from the individual drivers as having > > COMPILE_TEST for IMX_SCU is enough to be able to select the drivers. > > Thanks, I already added the COMPILE_TEST for IMX_SCU which is in this same patch series, > without that IMX_SCU COMPILE_TEST patch, the build will failed, so in V2, I also added > the stubs into those IMX SCU APIs to make sure even IMX_SCU is NOT enabled, modules > with COMPILE_TEST can still pass build, please help review V2 patch set. > My point is that there is no need for the stubs. Simply have COMPILE_TEST for IMX_SCU as this is enough to extend coverage to all the drivers and significantly reduces the code size versus what you did in v2. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
