Hi Dmitry, We have a Dell desktop with ps2 addon card, after S3, the ps2 keyboard lost function and got below errors Jan 15 07:10:08 Rh-MT kernel: [ 346.575353] i8042: i8042 controller selftest timeout Jan 15 07:10:08 Rh-MT kernel: [ 346.575358] PM: Device i8042 failed to resume: error -19 Adding this patch, I found the selftest passes at the second retry and the keyboard continue working fine. Best regards, AceLan Kao. Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> 於 2020年3月6日 週五 下午12:16寫道： > > Hi AceLan, > > On Thu, Mar 05, 2020 at 02:44:23PM +0800, AceLan Kao wrote: > > It returns -NODEV at the first selftest timeout, so the retry logic > > doesn't work. Move the return outside of the while loop to make it real > > retry 5 times before returns -ENODEV. > > The retry logic here was for the controller not returning the expected > selftest value, not the controller refusing to communicate at all. > > Could you pease tell me what device requires this change? > > Thanks. > > -- > Dmitry
