On Mon, 2020-03-02 at 16:40 +0100, Hans de Goede wrote: > > Does this mean we retry at most once? > > > Yes, we are not really "retrying", we are doing a 2 step > > probe: > > > > 1) First try to get the GPIOs without having done our heuristics and > > without having called devm_acpi_dev_add_driver_gpios(). This is for > > ACPI platforms extra GPIO info (including names) using the special > > ACPI "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID method. > > > > 2) If this fails then we add our own name to index mappings and > > get the GPIOs using those. Is there a better way to communicate that? Using a separate function for that piece of code, and maybe some comments to clarify what it's doing. Thanks for the other explanations.