Re: [PATCH resend 04/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2020-03-02 at 16:40 +0100, Hans de Goede wrote:
> > Does this mean we retry at most once?
> 
> 
> Yes, we are not really "retrying", we are doing a 2 step
> 
> probe:
> 
> 
> 
> 1) First try to get the GPIOs without having done our heuristics and
> 
> without having called devm_acpi_dev_add_driver_gpios(). This is for
> 
> ACPI platforms extra GPIO info (including names) using the special
> 
> ACPI "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID method.
> 
> 
> 
> 2) If this fails then we add our own name to index mappings and
> 
> get the GPIOs using those.

Is there a better way to communicate that? Using a separate function
for that piece of code, and maybe some comments to clarify what it's
doing.

Thanks for the other explanations.




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux