Hi, On 14/02/2020 15:49, Sebastian Reichel wrote: > Hi, > > On Fri, Feb 14, 2020 at 02:02:48PM +0100, Merlijn Wajer wrote: >> Instead, expose the key via the input framework, as SW_MACHINE_COVER > > How about: > > The chip-detect GPIO is actually detecting if the cover is closed. > Technically it's possible to use the SD card with open cover. The > only downside is risk of battery falling out and user being able > to physically remove the card. > > The behaviour of SD card not being available when the device is > open is unexpected and creates more problems than it solves. There > is a high chance, that more people accidently break their rootfs > by opening the case without physically removing the card. Sounds good. > Missing SoB. Will add. > Patch itself is > > Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> Thanks. Cheers, Merlijn
Attachment:
signature.asc
Description: OpenPGP digital signature
