Re: [PATCH 1/1] HID: hiddev: remove a duplicated check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/1/14 22:19, Jiri Kosina wrote:
> On Tue, 14 Jan 2020, Leizhen (ThunderTown) wrote:
> 
>> Does no one pay attention to this problem? Although there is no
>> functional problem, but it seems confusing.
>>
>>         if (!list->hiddev->exist) {                 <---------
>>                 res = -ENODEV;                                |
>>                 goto bail_unlock;                             |
>>         }                                                     |
>>         if (!list->hiddev->open++)                            |
>>                 if (list->hiddev->exist) {          <--------- //It's always true.
> 
> This code no longer exists after refactoring that happened in commit 
> 18a1b06e5b91d47.
OK

> 




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux