On Tue, Jan 7, 2020 at 7:38 AM Bastien Nocera <hadess@xxxxxxxxxx> wrote: > > On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote: > > Convert the Goodix binding to DT schema format using json-schema > > I don't have an opinion on the migration itself, but this really should > not lose any of the descriptions that were in the old text file. To some extent, yes. Any information specific to the device should be. Anything generic can be dropped. I see 2 cases that should be kept: > > - - reg : I2C address of the chip. Should be > > 0x5d or 0x14 'I2C address of the chip' can be dropped as that's every 'reg' property for I2C devices. The addresses can be expressed as constraints. > > - - irq-gpios : GPIO pin used for IRQ. The driver uses the > > - interrupt gpio pin as output to reset the > > device. Also useful info. Rob
