On Mon, Dec 09, 2019 at 10:16:26AM -0600, Rob Herring wrote: > On Sun, Dec 8, 2019 at 6:54 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > On Thu, Dec 05, 2019 at 07:56:10AM -0600, Rob Herring wrote: > > > On Wed, Dec 4, 2019 at 6:25 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > > > > > Add support for clock-based vibrator devices where the speed can be > > > > controlled by changing the duty cycle. > > > > > > > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> > > > > --- > > > > .../bindings/input/clk-vibrator.yaml | 60 +++++++++++++++++++ > > > > 1 file changed, 60 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/clk-vibrator.yaml b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > new file mode 100644 > > > > index 000000000000..2103a5694fad > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > @@ -0,0 +1,60 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/bindings/input/clk-vibrator.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Clock vibrator > > > > + > > > > +maintainers: > > > > + - Brian Masney <masneyb@xxxxxxxxxxxxx> > > > > + > > > > +description: | > > > > + Support for clock-based vibrator devices where the speed can be controlled > > > > + by changing the duty cycle. > > > > + > > > > +properties: > > > > + compatible: > > > > + const: clk-vibrator > > > > + > > > > + clocks: > > > > + maxItems: 1 > > > > + > > > > + clock-names: > > > > + description: output clock that controls the speed > > > > + items: > > > > + - const: core > > > > > > No point in making up a name when there's only one clock, so drop. > > > > OK, will do. > > > > > > > > > + > > > > + clock-frequency: true > > > > > > Given the frequency is variable, what does this mean in this case? > > > > The clock frequency is fixed. The duty cycle is what's variable. > > That sounds like a PWM then... Yes... See this message from Stephen with some more background information about why this is in the clk subsystem: https://lore.kernel.org/lkml/20190627234929.B78E520815@xxxxxxxxxxxxxxx/ Brian
