Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?
Best regards
Yannick Fertré
-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Sent: dimanche 1 décembre 2019 04:08
To: Yannick FERTRE <yannick.fertre@xxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>
Cc: Philippe CORNU <philippe.cornu@xxxxxx>; Benjamin GAIGNARD <benjamin.gaignard@xxxxxx>; Bastien Nocera <hadess@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel
On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@xxxxxx>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
If it is compatible with gt912 then the driver does not need another compatible in the code I think. Rob will tell more.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@xxxxxx>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>
--
Dmitry
