Hi Dmitry, On Mon, Nov 18, 2019 at 02:32:36PM +0100, Stephan Gerhold wrote: > Hi Dmitry, > > On Tue, Oct 22, 2019 at 02:18:39PM +0300, Andi Shyti wrote: > > Hi Dmitry, > > > > > If regmap is too much work then as a stop gap we could maybe only > > > convert write functions and mention why read needs to be custom. > > > > regmap is not too much work but I don't have the device with me, > > I might get one at some point, but can't do anything right now. > > > > Perhaps, for now you can take Stephan's patches and I would > > update everything once I get the device. They are not mutually > > exclusive, anyway. > > What do you think about this? > > My patches for MMS345L keep behavior for MMS114 and MMS152 as-is, > so we can be sure that there are no regressions for them. > > Cleaning up the driver to use SMBUS and/or regmap instead of the custom > read/write methods is definitely something we should attempt to do > at some point, but only when we can properly test them on MMS114. > > Until we have a MMS114 test device available, I would say that > applying my patches is the least intrusive way to make MMS345L work. > I would really like to find a solution for this. If it helps, I can re-send my patches for MMS345L (although they still apply cleanly...). Let me know what you would prefer! Thanks, Stephan
