On 27 November 2019 13:23, Marco Felsch wrote:
> There was a bug within the driver since commit f889beaaab1c ("Input:
> da9063 - report KEY_POWER instead of KEY_SLEEP during power
> key-press"). Since we fixed the bug the KEY_POWER will be reported
> always so we need to adapt the dt-bindings too. Make the description
> more precise while on it.
>
> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> ---
> v2:
> - change description according Dmitry's suggestion.
>
> Documentation/devicetree/bindings/input/da9062-onkey.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> index 0005b2bdcdd7..9f895454179d 100644
> --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> @@ -15,9 +15,8 @@ Required properties:
>
> Optional properties:
>
> -- dlg,disable-key-power : Disable power-down using a long key-press. If this
> - entry exists the OnKey driver will remove support for the KEY_POWER key
> - press when triggered using a long press of the OnKey.
> +- dlg,disable-key-power : If this property is present, the host will not be
> + issuing shutdown command over I2C in response to a long key-press.
This also changes behaviour of button press reporting as the driver will not
report a longer press (i.e. a button hold where the driver polls for release).
It will only report a short key press to user-space with this property provided.
The question here is do we still want to support long press reporting but
without the I2C sequence for shutdown? If so the driver needs to be updated to
work this way as right now it doesn't.
>
> - dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the
> otp values. See nONKEY_PIN register description for more information.
> --
> 2.20.1
