Re: [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 21, 2019 at 02:20:46PM +0100, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@xxxxxxxxx>
> 
> Make selection of the driver a bit easier by replacing depends on
> KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
> before being able to enable INPUT_SOC_BUTTON_ARRAY.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx>
> ---
>  drivers/input/misc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 7d9ae394e597..99d263177d8d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -813,7 +813,8 @@ config INPUT_IDEAPAD_SLIDEBAR
>  
>  config INPUT_SOC_BUTTON_ARRAY
>  	tristate "Windows-compatible SoC Button Array"
> -	depends on KEYBOARD_GPIO && ACPI
> +	depends on ACPI
> +	select KEYBOARD_GPIO

KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
dependencies, so you may still end up with invalid configs...

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux