On Wed, Nov 13, 2019 at 12:34:21AM +0100, Sebastian Reichel wrote: > Hi, > > On Tue, Nov 12, 2019 at 11:44:27AM -0500, Sven Van Asbroeck wrote: > > The driver's method to retrieve the firmware version on ili2117/ > > ili2118 chip flavours is incorrect. The firmware version register > > address and layout are wrong. > > > > The firmware version is not actually used anywhere inside or > > outside this driver. There is a dev_dbg() print, but that is > > only visible when the developer explicitly compiles in debug > > support. > > > > Don't make the code more complicated to preserve a feature that > > no-one is using. Remove all code associated with chip firmware > > version. > > > > Link: https://lore.kernel.org/lkml/20191111181657.GA57214@dtor-ws/ > > Cc: Marek Vasut <marex@xxxxxxx> > > Cc: Adam Ford <aford173@xxxxxxxxx> > > Cc: <linux-kernel@xxxxxxxxxxxxxxx> > > Cc: linux-input@xxxxxxxxxxxxxxx > > Tree: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/?h=next > > Signed-off-by: Sven Van Asbroeck <TheSven73@xxxxxxxxx> > > --- > > The firmware version check does one relevant thing: It tests > the I2C communication, which tends to be useful for board > bringup and development boards (which often allow to disconnect > (touch-)screens). If/when this is needed I propose we add a separate "lite" xfer check, similar to what elants_i2c and many other drivers are doing. Thanks. -- Dmitry
