Hi Dmitry, On Mo, 2019-11-04 at 16:03 -0800, Dmitry Torokhov wrote: > On Mon, Nov 04, 2019 at 12:44:53PM +0100, Lucas Stach wrote: > > F54 is IRQ capable, even if it is not used in the current driver > > implementation. The common driver code in rmi_create_function_irq always > > installs a irq handler for functions that are IRQ capable. Without a > > assigned attention handler, this means a NULL pointer being passed as > > the nested IRQ handler. This seems to work with some architecture > > implementations, but crashes on others like ARM64. > > > > Don't rely on implementation defined behavior and actually install > > a proper attention handler. > > Instead of supplying dummy IRQ handler, can't we simply disable relevant > interrupts bits? Don't know why I didn't try this last time. I vaguely remember that not enabling the IRQs didn't help. I just retested and it seems the IRQs are enabled by default, so we need to actively disable them. I just sent out a patch which does exactly this. Regards, Lucas
