Hi Saiyam, On Thu, Oct 24, 2019 at 11:38:22PM +0530, Saiyam Doshi wrote: > On Sun, Sep 01, 2019 at 11:53:09PM +0530, Saiyam Doshi wrote: > > In sx8654_probe function, if call to device_get_match_data() > > return NULL, it dereferences driver_data from 'id'. > > > > To avoid NULL pointer dereference, add check to make sure > > 'id' is not NULL. > > Any review / update on this? Can you please explain under what circumstances we can get NULL from device_get_match_data() in this driver? Thanks. -- Dmitry