On Wed, Oct 23, 2019 at 09:06:29PM +0200, Helge Deller wrote: > On 23.10.19 17:22, Alexandre Belloni wrote: > > On 23/10/2019 16:25:02+0200, Arnd Bergmann wrote: > > > The driver contains half of the implementation of /dev/rtc, but this > > > was never completed, and it is now incompatible with the drivers/rtc > > > framework. > > > > > > Remove the chardev completely. If anyone wants to add the functionality > > > later, that shoudl be done through rtc_register_device(). > > > > > > The remaining portions of the driver basically implement a single > > > procfs file that may or may not be used anywhere. Not sure why this > > > is in drivers/input/ though. > > > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > A year ago I did actually converted this driver to the RTC framework. > But after some testing on my physical box (a 715/64 PA-RISC machine > with HIL connector) I realized that the SDC in that machine doesn't > provide a functional RTC, and even more important, on that box we don't > need this RTC because the system provides a built-in RTC on-mainboard instead. > So, I never pushed my changes upstream, which can still be found here: > https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=hp_sdc_rtc_conversion&id=0d4250dbcfa2bb8b326ce7721e19e10a66f1eb92 > > So, I don't think any PA-RISC machine needs this driver, and as such > I'm happy to give my: > Acked-by: Helge Deller <deller@xxxxxx> Applied, thank you. > > I even think the whole driver can go away... > > Helge > > PS: Maybe some really old 68000-based HP machines needed that, but > I don't know if any recent Linux kernel runs on those old boxes any > longer... Well, if you think it is unlikely that we need this driver just send me a patch. We can always restore it if someone yells. Thanks. -- Dmitry
