On Fri, Oct 18, 2019 at 05:41:44PM +0200, Arnd Bergmann wrote: > To avoid a dependency on the pxa platform header files with > hardcoded registers, change the driver to call a wrapper > in the pxa2xx-ac97-lib that encapsulates all the other > ac97 stuff. Not supper happy about adding module dependencies. Can we include mach/regs-ac97.h from include/sound/pxa2xx-lib.h and use static inlines? Someone needs to include mach/regs-ac97.h in the end... Or there is something later in the series that needs it? Thanks. -- Dmitry