Re: [PATCH 1/5] Input: pixcir_i2c_ts - Remove unneeded gpio.h header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08. 10. 19 20:44, Dmitry Torokhov wrote:
On Tue, Oct 08, 2019 at 01:11:15PM +0300, Roger Quadros wrote:
Hi,

On 07/10/2019 15:16, Fabio Estevam wrote:
The touchscreen device is a GPIO consumer, not a GPIO controller,
so there is no need to include <linux/gpio.h>.

Remove the unneeded header file.

Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>

For all 5 patches,

Reviewed-by: Roger Quadros <rogerq@xxxxxx>

I guess we can also do this:

Input: pixcir_i2c_ts - remove platform data

From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Previous change moved platform data definition into the driver, making it
unusable for users. Given that we want to move away from custom platform
data structures, and always use device properties (DT, ACPI or static) to
configure devices, let's complete the removal.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
---
  drivers/input/touchscreen/pixcir_i2c_ts.c |  100 +++++++----------------------
  1 file changed, 25 insertions(+), 75 deletions(-)

Compiled and boot tested the whole series including this patch from Dmitry
on our imx6dl-yapp4-draco with Pixcir Tango C48.

Everything still works for me, thanks!

Tested-by: michal.vokac@xxxxxxxxx



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux