On Thu, 3 Oct 2019, Hans de Goede wrote: > > have one remaining question -- what is the reason you decided to factor > > this out as a separate driver, instead of putting it under the > > hid-logitech umbrella? > > I put this in a separate driver, because it is a substantial chunk of code > and the gaming keyboard stuff shares nothing what so ever with the other > Logitech bits. Well, we generally keep the support really divided on the vendor granularity, even if code sharing for individual models is minimal. I mostly personally prefer that due to absolute clarity for people making CONFIG_ decisions, but as you put that under the generic Logitech config, it's not a big issue. Queued in for-5.5/logitech now. -- Jiri Kosina SUSE Labs
