> From: dmitry.torokhov@xxxxxxxxx <dmitry.torokhov@xxxxxxxxx> > Sent: Thursday, October 3, 2019 10:46 AM > > > > I think I understood now: it looks the vmbus driver should implement > > a prepare() or freeze(), which calls the hyperv_keyboard driver's > > prepare() or freeze(), which can set the flag or disable the keyboard > > event handling. This way we don't need the notifier. > > Right. I think in practice the current suspend implementation can work > as freeze() for the HV keyboard, because in suspend you shut off vmbus > channel, so there should not be wakeup signals anymore. What you do not > want is to have the current resume to be used in place of thaw(), as > there you re-enable the vmbus channel and resume sending wakeup requests > as you are writing out the hibernation image to storage. > > I think if vmbus allowed HV keyboard driver to supply empty thaw() and > poweroff() implementations, while using suspend() as freeze() and > resume() as restore(), it would solve the issue for you. > > Dmitry Exactly. I'll have to fix vmbus first, then post a v2 for this patch. Thanks, -- Dexuan
