On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@xxxxxxxx> wrote: > asm/io.h may not be included implicitly, causing a rare > randconfig build error: > > drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration] > __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE, > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> I am thinking a bit about the future of this driver. Isn't it more reasonable to just make a hrtimer-driven PWM and use the existing PWM userspace ABI and timer framework in Linux for this? Not that there is a generic timer-driven PWM but ... that is essentially what this driver is. Yours, Linus Walleij
