Hi, Pavel > Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding > > Hi! > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and power key event etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get power key > > event, add binding doc for i.MX system controller power key driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -157,6 +157,15 @@ Required properties: > > Optional properties: > > - timeout-sec: contains the watchdog timeout in seconds. > > > > +Power key bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: should be: > > + "fsl,imx8qxp-sc-pwrkey" > > + followed by "fsl,imx-sc-pwrkey"; > > +- linux,keycodes: See > > +Documentation/devicetree/bindings/input/keys.txt > > Actually there's no reason for having "linux,keycodes" property when it is > always a power button. The latest version of patch already change the compatible name to *-sc-key which is more general as key driver, so the "linux,keycodes" is needed now for driver to define the key function. Thanks, Anson
