On Sat, Aug 31, 2019 at 12:27:11PM +0200, Hans de Goede wrote: > Hi, > > On 29-08-19 19:51, Dmitry Torokhov wrote: > > On Wed, Aug 28, 2019 at 02:41:24PM +0200, Hans de Goede wrote: > > <snip> > > > > This commit adds the following new KEY_ defines for this: > > > > > > KEY_MACRO1 - KEY_MACRO30. KEY_MACRO_RECORD_START/-STOP, > > > KEY_MACRO_PRESET_CYCLE, KEY_MACRO_PRESET1 - KEY_MACRO_PRESET3, > > > KEY_KBD_LCD_MENU1 - KEY_KBD_LCD_MENU5. > > > > > > The defines leave room for adding some more LCD-menu, preset or macro keys, > > > the maximum values above are based on the maximum values to support all > > > currently known internet, office and gaming keyboards. > > > > > > BugLink: https://github.com/libratbag/libratbag/issues/172 > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Thank you, does this mean that you are ok with merging this through the > hid tree as part of the rest of the series ? Yes, please feel free to merge though HID. -- Dmitry