On Fri, Aug 23, 2019 at 4:48 PM Filipe Laíns <lains@xxxxxxxxxxxxx> wrote: > > On Fri, 2019-08-23 at 16:32 +0200, Benjamin Tissoires wrote: > > The problem I have with quirks, and that I explained to Filipe on IRC > > is that this is kernel ABI. Even if there is a very low chance we have > > someone using this, re-using the same drv_data bit in the future might > > break someone's device. > > But we can reserve those bits. I don't expect there to be a ton of > devices that need to be quirked, so using the remaining bits should be > perfectly fine. Do you agree? Nope. If the code is not ready for upstream, it should not be included. Cheers, Benjamin
