Re: [PATCH 2/3] input: Add SW_UNSUPPORT_INSERT define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Banajit,

On Fri, May 24, 2019 at 01:40:38PM -0700, bgoswami@xxxxxxxxxxxxxx wrote:
> From: Banajit Goswami <bgoswami@xxxxxxxxxxxxxx>
> 
> Some devices may not support specific type of input devices. For example,
> when a headset or extension cable with GND/MIC swap is plugged into a
> headset jack that does not support the headset/cable, it needs to be
> reported with a corresponding input event. Also, increase the max values
> for INPUT_DEVICE_ID_SW_MAX and SW_MAX, to accommodate future extension of
> the number of event.

I do not think that adding this switch is a good idea as it will not
allow you to easily extend the reporting and to convey to the user why
something is not supported. I would look into alternate mechanism to
signal when and why a headset/peripheral was rejected.

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux