On 20.08.19 13:17, Pali Rohár wrote:
On Tuesday 20 August 2019 12:56:12 Enrico Weigelt, metux IT consult wrote:From: Enrico Weigelt <info@xxxxxxxxx> IS_ERR() already calls unlikely(), so this extra unlikely() call around IS_ERR() is not needed. Signed-off-by: Enrico Weigelt <info@xxxxxxxxx> --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 34700ed..ed16614 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, /* On V2 devices the DualPoint Stick reports bare packets */ dev = priv->dev2; dev2 = psmouse->dev; - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { + } else if (IS_ERR_OR_NULL(priv->dev3)) { /* Register dev3 mouse if we received PS/2 packet first time */ if (!IS_ERR(priv->dev3)) psmouse_queue_work(psmouse, &priv->dev3_register_work,Hello! Two months ago I already saw this patch. See discussion: https://patchwork.kernel.org/patch/10977099/
phuh, that's long chain of links to folow ;-) So, your primary argument is just *documenting* that this supposed to be a rare condition ? In that case, wouldn't a comment be more suitable for that ? It seems that this issue is coming up again and again ... when people run cocci scans (like I didn't), I'd suspect this to happen even more in the future. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
