On Wed, Mar 27, 2019 at 02:39:24PM +0100, Marco Felsch wrote: > Convert to devm function to drop the 'no-mem' error handling path and > strip down the remove funciton a bit. > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> I am not fond of partial devm conversions, as this causes reordering in of freeing resources in unwind path. In this particular case input device will be unregistered only after majority of the driver structure is torn down. If we want to do devm conversion, we need to do a complete one. Thanks. -- Dmitry