Re: [PATCH] Input: bu21013_ts: Convert to use GPIO descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

On Thu, Aug 08, 2019 at 04:44:58PM +0200, Linus Walleij wrote:
> @@ -266,7 +269,7 @@ static irqreturn_t bu21013_gpio_irq(int irq, void *device_data)
>  			return IRQ_NONE;
>  		}
>  
> -		data->intr_pin = gpio_get_value(data->chip->touch_pin);
> +		data->intr_pin = gpiod_get_value(data->int_gpiod);
>  		if (data->intr_pin == PEN_DOWN_INTR)
>  			wait_event_timeout(data->wait, data->touch_stopped,
>  					   msecs_to_jiffies(2));

So the INT pin appears to be active low (PEN_DOWN_INTR is 0), so we'll
need to adjust DTS for the boards as such and change this to "logical
active" here since we are moving to gpiod API.

I'll adjust the code in the version I will be sending you soon(ish).

Thanks.

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux