On Thu, Aug 08, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > On Thu, Aug 8, 2019 at 11:43 PM Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: > > > > Hi Arnd, > > > > On Thu, Aug 08, 2019 at 11:22:22PM +0200, Arnd Bergmann wrote: > > > By using the new linux/soc/ti/omap1-io.h header instead, > > > compile-testing can be enabled, and a CONFIG_ARCH_MULTIPLATFORM > > > conversion of omap1 may eventually be possible. > > > > > > The warning in the header file gets removed in order to > > > allow CONFIG_COMPILE_TEST. > > > > Given that we want to migrate people off this driver everywhere but > > OMAP1 I wonder why we would want to improve compile coverage of it. > > Mainly for consistency: I'm converting all omap1 drivers in this series to > not rely on mach/* headers and to let them be compiled standalone. > The other drivers don't have a replacement, so I could treat this different > from the rest and skip the Kconfig and platform_data changes if you > prefer. Yes, because at least with the version you posted we are losing the #warning telling people to move to matrix_keypad. We could do: #ifndef CONFIG_COMPILE_TEST #warning ... #endif if you really want to allow compiling standalone for testing. Thanks. -- Dmitry
