Re: [PATCH] usbtouchscreen: add proper initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 30, 2019 at 12:47:17PM +0200, Oliver Neukum wrote:
> Mutexes shall be initialized before they are used.
> 
> Fixes: 12e510dbc57b2 ("Input: usbtouchscreen - fix deadlock in autosuspend")
> Reported-by: syzbot+199ea16c7f26418b4365@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>

Applied, thank you.

> ---
>  drivers/input/touchscreen/usbtouchscreen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
> index a2cec6cacf57..caacf211f51b 100644
> --- a/drivers/input/touchscreen/usbtouchscreen.c
> +++ b/drivers/input/touchscreen/usbtouchscreen.c
> @@ -1658,6 +1658,7 @@ static int usbtouch_probe(struct usb_interface *intf,
>  	input_dev = input_allocate_device();
>  	if (!usbtouch || !input_dev)
>  		goto out_free;
> +	mutex_init(&usbtouch->pm_mutex);
>  
>  	type = &usbtouch_dev_info[id->driver_info];
>  	usbtouch->type = type;
> -- 
> 2.16.4
> 

-- 
Dmitry



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux